Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove versioned logic in loguru instrumentation #1222

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

umaannamalai
Copy link
Contributor

Remove versioned logic in loguru instrumentation as per agent support window.

@umaannamalai umaannamalai requested a review from a team as a code owner September 25, 2024 20:22
Copy link

github-actions bot commented Sep 25, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.63s
✅ PYTHON black 5 0 0 0.86s
❌ PYTHON flake8 5 1 0.45s
✅ PYTHON isort 5 0 0 0.3s
✅ PYTHON pylint 5 0 3.6s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.23%. Comparing base (4768fba) to head (5618f78).

Files with missing lines Patch % Lines
newrelic/hooks/logger_loguru.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1222      +/-   ##
==========================================
- Coverage   81.26%   81.23%   -0.03%     
==========================================
  Files         197      197              
  Lines       21601    21598       -3     
  Branches     3776     3775       -1     
==========================================
- Hits        17554    17546       -8     
- Misses       2908     2912       +4     
- Partials     1139     1140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umaannamalai umaannamalai merged commit 85f4035 into main Sep 26, 2024
51 of 52 checks passed
@umaannamalai umaannamalai deleted the remove-loguru-version-check branch September 26, 2024 16:38
@umaannamalai umaannamalai added this to the v10.0.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants